Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency and reduce duplication in PSP BSP implementation #121

Closed
skliper opened this issue Dec 16, 2019 · 0 comments · Fixed by #149
Closed

Improve consistency and reduce duplication in PSP BSP implementation #121

skliper opened this issue Dec 16, 2019 · 0 comments · Fixed by #149
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Dec 16, 2019

Is your feature request related to a problem? Please describe.
See nasa/osal#261, where this ticket is to address item 3 to reduce code duplication in the PSP's.

Describe the solution you'd like
The CFE PSP should be an extension of the OSAL BSP, not a replacement for it. The PSP already defines a CFE_PSP_Main() entry point for itself, and this can be invoked as a second-stage after OS_Application_Startup to do the additional startup tasks required for CFE.

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper mentioned this issue Dec 16, 2019
Closed
@skliper skliper added the enhancement New feature or request label Jan 7, 2020
jphickey added a commit to jphickey/PSP that referenced this issue Apr 3, 2020
@jphickey
Fix nasa#121, Unify CFE PSP with OSAL BSP
36c6974 
Instead of redefining the basic entry point symbols, use the
OSAL BSP and its abstractions.  The CFE PSP just becomes an
extension to the OSAL BSP, and only needs to define the
OS_Application_Startup symbol like any other OSAL application.
@jphickey jphickey mentioned this issue Apr 3, 2020
Merged
astrogeco added a commit that referenced this issue Apr 14, 2020
@astrogeco
Merge pull request #149 from jphickey/fix-121-unify-osal-bsp-psp
801bf27 
Fix #121, Unify CFE PSP with OSAL BSP
@astrogeco astrogeco mentioned this issue Apr 15, 2020
Merged
@astrogeco astrogeco added this to the 1.5.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #121, Unify CFE PSP with OSAL BSP jphickey/PSP
2 participants
@skliper @astrogeco