Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter CommandData hides a global variable with the same name. [lgtm] #122

Closed
avan989 opened this issue Dec 17, 2019 · 0 comments · Fixed by #130
Closed

Parameter CommandData hides a global variable with the same name. [lgtm] #122

avan989 opened this issue Dec 17, 2019 · 0 comments · Fixed by #130
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 17, 2019

Describe the bug

cfe_psp_start.c

void CFE_PSP_ProcessArgumentDefaults(CFE_PSP_CommandData_t *CommandData)
--
  | Parameter CommandData hides a global variable with the same name.

To Reproduce
Steps to reproduce the behavior:

  1. build against lgtm

Reporter Info
Anh Van, NASA Goddard
@skliper skliper added the enhancement New feature or request label Jan 7, 2020
astrogeco pushed a commit that referenced this issue Jan 13, 2020
@astrogeco
#122, fix lgtm issue
ab4c4b6
astrogeco pushed a commit that referenced this issue Jan 13, 2020
Fix #122, Rename parameter to avoid collision
1170718
astrogeco pushed a commit that referenced this issue Jan 13, 2020
CCB 20200108: Merge #122
b12cc81 
Fix #123
Reviewed and approved at 2020-01-08 CC
astrogeco pushed a commit that referenced this issue Jan 13, 2020
CCB 20200108: Merge #123
b0ef9f7 
Fix #122
Reviewed and approved at 2020-01-08 CCB
astrogeco pushed a commit that referenced this issue Jan 13, 2020
Fix #122, Rename parameter to avoid collision
e1f8042
astrogeco pushed a commit that referenced this issue Jan 13, 2020
CCB 20200108: Merge #123
bf61b54 
Fix #122
Reviewed and approved at 2020-01-08 CCB
@skliper skliper mentioned this issue Jan 15, 2020
Merged
@astrogeco astrogeco added this to the 1.5.0 milestone Oct 1, 2020
@astrogeco astrogeco changed the title lgtm issue Parameter CommandData hides a global variable with the same name. [lgtm] Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20200108 nasa/PSP
3 participants
@avan989 @skliper @astrogeco