-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement psps without relying on aux_source_directory #135
Comments
I think this would be a good change, and it would make PSP's more modular and therefore more consistent with apps and the way everything else works. With this the change to do an out-of-tree PSP is also more straightforward and logical. |
This is actually necessary in order to merge nasa/osal#312, so I'll do this. |
Would this along with the related source selection via cmake options make the psp module concept redundant? |
I actually liked the idea of going full-modular with PSP's. That is, the "psp name" simply translates to a list of modular components to build for platform support. I briefly experimented with this and I think it could work nicely. That is, in my experiment, the PSP was defined like this:
This is convenient in that any/all of those modules can exist out-of-tree, using the currently existing module/app search logic. |
Do not use aux_source_directory to assemble a list of source files. Instead, put a proper CMakeLists.txt file in each implementation and build the implementation separately from the shared/common parts. In addition to avoiding the aux_source_directory this allows PSP-specific compile definitions to be set on a per-implementation basis because it is defined separately.
I definitely like the single mechanism for defining the modules included the PSP as you show above, and using the existing search logic! Seems like a great simplification. |
Do not use aux_source_directory to assemble a list of source files. Instead, put a proper CMakeLists.txt file in each implementation and build the implementation separately from the shared/common parts. In addition to avoiding the aux_source_directory this allows PSP-specific compile definitions to be set on a per-implementation basis because it is defined separately.
Fix #135, Add separate CMakeLists.txt for each implementation
Is your feature request related to a problem? Please describe.
The CMake documentation presents the following caveat for
aux_source_directory
:Describe the solution you'd like
The targets should have a list of files that go into making the specific psps.
Requester Info
Andrei Zisu of Planetary Transportation Systems (Berlin, Germany).
The text was updated successfully, but these errors were encountered: