Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace exit(1) and exit(-1) with preferred macro EXIT_FAILURE #382

Closed
2 tasks done
thnkslprpt opened this issue Mar 13, 2023 · 0 comments · Fixed by #383
Closed
2 tasks done

Replace exit(1) and exit(-1) with preferred macro EXIT_FAILURE #382

thnkslprpt opened this issue Mar 13, 2023 · 0 comments · Fixed by #383

Comments

@thnkslprpt
Copy link
Contributor

Checklist

Describe the bug
PSP contains a few uses of exit(1) and 'exit(-1)'.
Copy of nasa/tblCRCTool#77

Expected behavior
Recommend replacing with the more expressive and more portable EXIT_FAILURE or 'EXIT_SUCCESS' macros.

Code snips

PSP/fsw/mcp750-vxworks/src/cfe_psp_support.c

Line 118 in 6fceb13

exit(-1); /* Need to improve this */

PSP/fsw/pc-rtems/src/cfe_psp_support.c

Line 84 in 6fceb13

exit(-1);

Reporter Info
Avi Weiss @thnkslprpt
thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Mar 13, 2023
@thnkslprpt
Fix nasa#382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro
c856201
@thnkslprpt thnkslprpt mentioned this issue Mar 13, 2023
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Mar 14, 2023
@thnkslprpt
Fix nasa#382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro
ad03fc8
thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Apr 6, 2023
@thnkslprpt
Fix nasa#382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro
cdc524f
thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Dec 11, 2023
@thnkslprpt
Fix nasa#382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro
9a47a7e
thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Dec 11, 2023
@thnkslprpt
Fix nasa#382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro
6ccf27b
dmknutsen added a commit that referenced this issue Dec 15, 2023
@dmknutsen
Merge pull request #383 from thnkslprpt/fix-382-replace-exit-1-with-e…
f27c73e 
…xit-failure

Fix #382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #382, Replace exit(1) and exit(-1) with EXIT_FAILURE macro thnkslprpt/PSP
1 participant
@thnkslprpt