-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #66, Simplified code to use just the array names where correct #116
Conversation
Where may I sign the CLA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove Address-of operator &
where the [0]
's were removed.
Looks good. Could you squash with the commit message "Fix #66, Simplify address-of element 0"? |
16a0112
to
3e9e6d1
Compare
CLA form for cFE elements (includes PSP) is now in the system, take a look at the last few lines of (includes link to form): https://github.com/nasa/PSP/blob/master/.github/pull_request_template.md |
If you could let me know when the CLA has been submitted I can expedite processing of this commit. Note email on the form is preferred (see submit instructions at the end of the form). Thanks for contributing! |
Hi @skliper, sorry for the delay but the links at the bottom of the page seem to be broken. |
Thanks @zufishanali for the feedback! Fixed in latest master. |
Hi @skliper, the signed CLA has been submitted. |
Hi @zufishanali, I can confirm it has been received. Thanks! |
CCB 20200212 - Approved |
Describe the contribution
Fixes issue #66.
Made changes to file
mcp750-vxworks/src/cfe_psp_memory.c
in order to simply code to use just the array names when correct. Used grep to find any instances as instructed.Contributor Info
Zufishan Ali, Seneca College of Applied Arts & Technology
Community contributors
Pending: You must attach a signed CLA (required for acceptance) or reference one already submitted