Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #66, Simplified code to use just the array names where correct #116

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

zufishanali
Copy link
Contributor

Describe the contribution
Fixes issue #66.

Made changes to file mcp750-vxworks/src/cfe_psp_memory.c in order to simply code to use just the array names when correct. Used grep to find any instances as instructed.

Contributor Info
Zufishan Ali, Seneca College of Applied Arts & Technology

Community contributors
Pending: You must attach a signed CLA (required for acceptance) or reference one already submitted

@zufishanali
Copy link
Contributor Author

Where may I sign the CLA?

Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove Address-of operator & where the [0]'s were removed.

@skliper
Copy link
Contributor

skliper commented Dec 10, 2019

Looks good. Could you squash with the commit message "Fix #66, Simplify address-of element 0"?

@skliper skliper added the CCB:PendingCLA External contribution pending CLA confirmation label Jan 22, 2020
@skliper
Copy link
Contributor

skliper commented Jan 22, 2020

CLA form for cFE elements (includes PSP) is now in the system, take a look at the last few lines of (includes link to form):

https://github.com/nasa/PSP/blob/master/.github/pull_request_template.md

@skliper
Copy link
Contributor

skliper commented Jan 22, 2020

If you could let me know when the CLA has been submitted I can expedite processing of this commit. Note email on the form is preferred (see submit instructions at the end of the form).

Thanks for contributing!

@zufishanali
Copy link
Contributor Author

CLA form for cFE elements (includes PSP) is now in the system, take a look at the last few lines of (includes link to form):

https://github.com/nasa/PSP/blob/master/.github/pull_request_template.md

Hi @skliper, sorry for the delay but the links at the bottom of the page seem to be broken.

@skliper
Copy link
Contributor

skliper commented Jan 30, 2020

Thanks @zufishanali for the feedback! Fixed in latest master.

@zufishanali
Copy link
Contributor Author

Hi @skliper, the signed CLA has been submitted.
Thanks!

@skliper
Copy link
Contributor

skliper commented Feb 10, 2020

Hi @zufishanali, I can confirm it has been received. Thanks!

@skliper skliper added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) and removed CCB:PendingCLA External contribution pending CLA confirmation labels Feb 10, 2020
@skliper skliper added this to the 1.5.0 milestone Feb 10, 2020
@skliper skliper linked an issue Feb 10, 2020 that may be closed by this pull request
@astrogeco astrogeco changed the title Fixes #66 - Simplified code to use just the array names where correct Fix #66 - Simplified code to use just the array names where correct Feb 11, 2020
@astrogeco astrogeco changed the title Fix #66 - Simplified code to use just the array names where correct Fix #66, Simplified code to use just the array names where correct Feb 11, 2020
@astrogeco
Copy link
Contributor

CCB 20200212 - Approved

@astrogeco astrogeco added CCB:Approved Indicates Approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 13, 2020
@astrogeco astrogeco changed the base branch from master to ic-20200226 February 25, 2020 19:27
@astrogeco astrogeco merged commit 2225fbf into nasa:ic-20200226 Feb 25, 2020
@astrogeco astrogeco mentioned this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use (foo), not &(foo[0]), where appropriate
3 participants