Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #136, Remove local mcp750 header file #137

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Fix #136, Remove local mcp750 header file #137

merged 1 commit into from
Mar 9, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Feb 20, 2020

Describe the contribution
Removed in favor of using cross-compiler provided header
Fix #136

Testing performed
Steps taken to test the contribution:

  1. Diff'ed local file with cross-compiler version and they were identical
  2. Switched to ppc-vxworks6.9 toolchain and built with cross compiler, no issues

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS cross-compiler PC
  • OS: Linux 2.6
  • Versions: master bundle w/ this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper
Fix nasa#136, Remove local mcp750 header file
4f758cd 
Removed in favor of using cross-compiler provided header
@skliper skliper added enhancement New feature or request CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 20, 2020
@skliper skliper added this to the 1.5.0 milestone Feb 20, 2020
@astrogeco
Copy link
Contributor

CCB 20200226 - Approved

@astrogeco astrogeco added CCB - 20200226 CCB:Approved Indicates Approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Feb 26, 2020
@astrogeco astrogeco changed the base branch from master to ic-20200226 March 9, 2020 15:01
@astrogeco astrogeco merged commit 1ee4295 into nasa:ic-20200226 Mar 9, 2020
@astrogeco astrogeco mentioned this pull request Mar 10, 2020
Merged
@skliper skliper deleted the fix136-rm-mcpx750-hdr branch February 1, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates Approval by CCB enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Remove mcpx750.h
2 participants
@skliper @astrogeco