psp Integration candidate: 2021-04-06

[astrogeco]

Describe the contribution

PR #286

Fix #171, use OSAL timebase for CFE timers

Cleans up stale code from the previous methods of generating 1Hz. Adds a new PSP module that instantiates an OSAL abstract timebase for use with cFE services. This single module is used across all psp implementations (mcp750, pc-linux, pc-rtems). Results in 1Hz timing tick on MCP750 will be more accurate. No changes to Linux or RTEMS

PR #282

Fix #10, modularize the ram, port, and eeprom access

Fixes segfaults when CFE_PSP_Port routines are invoked on Linux.

Converts cfe_psp_ram.c and cfe_psp_port.c into modular components and removes from the "shared" directory. The existing implementations become the corresponding "direct" module, and are enabled based on the psp module selection. Adds a "notimpl" variant where all the functions return CFE_PSP_ERR_NOT_IMPLEMENTED. This is used on Linux
or any other system where direct access is not possible. Renames the existing eeprom_stub module to be eeprom_notimpl for consistency and to avoid
confusion with the unit test stubs.

PR #285

Fix #266, psp module to implement timebase

No impact to behavior. Implements two PSP modules to provide CFE_PSP_GetTime and CFE_PSP_GetTimeBase, one for POSIX-compliant RTOS using clock_gettime() and the other specifically for PowerPC processors on VxWorks that have the vxTimeBaseGet() routine. Clarifies and documents the difference and use cases for CFE_PSP_GetTime and CFE_PSP_GetTimeBase.

Adds a coverage test for the VxWorks PSP timebase module and provides an example of how this can be implemented for other modules.

Additional context

Part of nasa/cFS#238

Tests

psp Checks https://github.com/nasa/PSP/pull/289/checks
cFS Bundle https://github.com/nasa/cFS/pull/238/checks

Third party code

None

Authors

[astrogeco]

@jphickey there's something strange happenning with the cmake generated platform_module_list.c:

/* This file is generated via CMake - do not edit in place */
#include "cfe_psp_module.h"

extern CFE_PSP_ModuleApi_t CFE_PSP_soft_timebase_API;
;extern CFE_PSP_ModuleApi_t CFE_PSP_eeprom_mmap_file_API;


CFE_StaticModuleLoadEntry_t CFE_PSP_BASE_MODULE_LIST[] =
{
{ .Name = "soft_timebase", .Api = &CFE_PSP_soft_timebase_API },
;{ .Name = "eeprom_mmap_file", .Api = &CFE_PSP_eeprom_mmap_file_API },

{ NULL }
};

/* END OF FILE */

See the extra semicolon after both soft_timebase entries

[astrogeco]

Semicolon thingy fixed when I merged #282, I think there's similar logic in one of the CMakeLists files in cFE that may need to be updated to the string concatenate logic.

[jphickey]

Yes, the semicolon issue was a missing escape char (\) that I found as part of the #10 stuff - only showed up when using more than 1 module.

I think CFE is OK at this point.