-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #333, Relative strict-dir-list for static analysis workflow #334
Conversation
CCB:2022-04-13 APPROVED |
Fix #333, Relative strict-dir-list for static analysis workflow
@skliper this seems to be failing even thouth nasa/cFS#454 is merged. See 55a575e I was able to make it pass by removing the jobs:
static-analysis:
name: Run cppcheck
uses: nasa/cFS/.github/workflows/static-analysis.yml@main
with:
strict-dir-list: 'fsw' |
nasa/PSP#334, Fix input to static analysis workflow
Just to follow up, the failure seems to have been due to just rerunning the failed job which didn't pull in the new reusable workflow. Then after removing the leading |
nasa/PSP#334, Fix input to static analysis workflow
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Justing Figueroa <chillfigskliper@users.noreply.github.com>
**Combines** nasa/cFE#2091 v7.0.0-rc4+dev110 **Includes** *cFE* nasa/cFE#2077, Remove contributor license agreement nasa/cFE#2085, Use reusable documentation generation workflow nasa/cFE#2080, Add config module to coverage enforcemnt nasa/cFE#2081, Improve ES unit test coverage nasa/cFE#2082, Only increment SB InternalErrorCounter on errors *osal* nasa/osal#1246, Apply latest contributor license agreement links *PSP* nasa/PSP#331, Apply latest contributor license agreement links nasa/PSP#334, Fix input to static analysis workflow Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Justing Figueroa <chillfig@users.noreply.github.com>
Describe the contribution
Testing performed
Needs nasa/cFS#454 in main to actually test with CI
Expected behavior changes
Will work once nasa/cFS#454 is in
System(s) tested on
CI
Additional context
Depends on nasa/cFS#454, similar update as what's implemented in nasa/CF#228
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC