-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 128 increase test coverage #135
Merged
danielfromearth
merged 10 commits into
develop
from
feature/issue1-28-increase-test-coverage
Jun 27, 2024
Merged
Feature/issue 128 increase test coverage #135
danielfromearth
merged 10 commits into
develop
from
feature/issue1-28-increase-test-coverage
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #135 +/- ##
============================================
+ Coverage 14.92% 84.21% +69.28%
============================================
Files 4 4
Lines 134 133 -1
============================================
+ Hits 20 112 +92
+ Misses 114 21 -93 ☔ View full report in Codecov by Sentry. |
ank1m
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #128
Description
This change adds a mocked test of invoking batchee with the harmony adapter. It also adds a test of using batchee's grouping of TEMPO file names at the command line.
Local test steps
Added tests and passed.
Overview of integration done
Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.
PR Acceptance Checklist
CHANGELOG.md
updated