Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type mismatch between Cleanup stub and implementation #1023

Closed
4 tasks done
jphickey opened this issue Nov 17, 2020 · 0 comments · Fixed by #1024 or #1027
Closed
4 tasks done

Type mismatch between Cleanup stub and implementation #1023

jphickey opened this issue Nov 17, 2020 · 0 comments · Fixed by #1024 or #1027
Assignees
@jphickey
Labels
bug unit-test
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Nov 17, 2020 •
edited
Loading

Describe the bug
The stub of these functions is declared as taking a uint32 AppId parameter:

  • CFE_EVS_CleanUpApp
  • CFE_SB_CleanUpApp
  • CFE_TBL_CleanUpApp
  • CFE_TIME_CleanUpApp

Expected behavior
These need to be changed to CFE_ES_ResourceID_t to match FSW

System observed on:
Ubuntu 20.04

Additional context
Was not flagged as an error due to cfe_private.h not being included. After PR #1012 got merged, the stub mismatch is flagged.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/cFE that referenced this issue Nov 17, 2020
@jphickey
Fix nasa#1023, correct stub appid parameter
60e9e8f 
The type of this should be CFE_ES_ResourceID_t, not uint32
jphickey added a commit to jphickey/cFE that referenced this issue Nov 17, 2020
@jphickey
Fix nasa#1023, correct stub appid parameter
a129e8c 
The type of this should be CFE_ES_ResourceID_t, not uint32
@jphickey jphickey mentioned this issue Nov 17, 2020
Merged
@jphickey jphickey self-assigned this Nov 17, 2020
@astrogeco astrogeco added bug and removed enhancement labels Dec 1, 2020
@astrogeco astrogeco added this to the 7.0.0 milestone Dec 1, 2020
astrogeco added a commit that referenced this issue Dec 1, 2020
@astrogeco
Merge pull request #1024 from jphickey/fix-1023-stub-appid
0edf8c2 
Fix #1023, correct stub appid parameter
@astrogeco astrogeco mentioned this issue Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug unit-test
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @astrogeco