Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE coverage tests not getting built after re-org #1224

Closed
jphickey opened this issue Mar 16, 2021 · 0 comments · Fixed by #1225 or #1243
Closed

CFE coverage tests not getting built after re-org #1224

jphickey opened this issue Mar 16, 2021 · 0 comments · Fixed by #1225 or #1243
Assignees
Labels
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
After directory re-organization, it is missing the new recipes for building the CFE core coverage tests.

To Reproduce
Build+install with unit tests enabled. Everything runs and passes but the CFE core tests are not there.

Expected behavior
CFE core tests should be there

Code snips
Some empty placeholders in place of the real thing (mistake in original PR).

https://github.com/nasa/cFE/blob/2b8844871d374219cef7c0026e6c43460e11b22b/modules/es/ut-coverage/CMakeLists.txt

System observed on:
Ubuntu 20.04

Additional context
Unfortunately everything in tests+CI runs just fine without this being there, so it wasn't immediately noticeable that something was missing.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Mar 16, 2021
@jphickey jphickey added the bug label Mar 16, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Mar 16, 2021
Also requires fixing up some include directives in UT headers
jphickey added a commit to jphickey/cFE that referenced this issue Mar 16, 2021
This also fixes up/simplifies some include directives in UT headers

Additionally this updates UT_ResetState() in ut_support to always
configure the AppId for CFE_ES_GetAppId.  Unfortunately some TBL test
cases require/assume the "real" app IDs.  This works around the issue
and allows TBL tests to pass.  (This is really a weakness/fragility in
TBL tests).
astrogeco added a commit that referenced this issue Mar 17, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants