Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support larger tables in the table unit test #1655

Closed
skliper opened this issue Jun 30, 2021 · 0 comments · Fixed by #1656 or #1661
Closed

Support larger tables in the table unit test #1655

skliper opened this issue Jun 30, 2021 · 0 comments · Fixed by #1656 or #1661
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Jun 30, 2021

Is your feature request related to a problem? Please describe.
The first limitation hit is TBL services needs CFE_PLATFORM_TBL_MAX_SIMULTANEOUS_LOADS * CFE_PLATFORM_TBL_MAX_SNGL_TABLE_SIZE from the memory pool for setting up the load buffers. Easy to exhaust the buffer set up in ut_support.c:

typedef union
{
long long int AlignLong;
long double AlignDbl;
void * AlignPtr;
char Content[128 * 1024];
} UT_Buffer_t;
static UT_Buffer_t UT_CFE_ES_MemoryPool;

Describe the solution you'd like
Size the buffer used in unit test based on the configured sizes.

Describe alternatives you've considered
Could remove the buffer set up in ut_support.c for CFE_ES_GetPoolBuf and size it everywhere, or could override the handler with something simpler that supports the specific test.

Additional context
Causing stakeholder unit test failures.

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Jun 30, 2021
@skliper skliper self-assigned this Jun 30, 2021
astrogeco added a commit that referenced this issue Jul 7, 2021
Fix #1655, Size unit test table load buffer based on config
paulober pushed a commit to paulober/cFE that referenced this issue Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant