Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamps to EVS logging to stdout #219

Closed
skliper opened this issue Sep 30, 2019 · 5 comments · Fixed by #2295
Closed

add timestamps to EVS logging to stdout #219

skliper opened this issue Sep 30, 2019 · 5 comments · Fixed by #2295
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Often it's useful to know the time a message is generated in the stdout log. Adding a timestamp to EVS_SendViaPorts() as an option would be helpful.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 188. Created by cdknight on 2017-03-30T13:47:22, last modified: 2019-07-03T12:58:32

@skliper skliper added this to the 6.8.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by cdknight on 2017-03-30 13:52:52:

I've pushed the code to the trac-188-evs_timestamps branch; the current code remains but if CFE_EVS_ENH_OUT, the enhanced output options are enabled. All output fields can be turned on/off using #defines in the platform_cfg.h

See [changeset:fec456e].

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by glimes on 2017-05-03 12:15:27:

My notes on this were a bit confused, so to make sure I'm on the right page, here are the notes from the 2017-04-17 CCB meeting:

CCB Approved and Deferred.

The CCB approved concept and ticket for 6.6.0 release. The changes documented below will be applied and reviewed for integration to development.

  • Should the switch be a platform or mission configuration? Agreement may want to support different output on different platforms so keep this a platform configuration switch.
  • Platform configuration macros need to follow the naming standard.
  • Should there be such a detailed level of granularity as to which information should get enabled/disabled in the stdout event message? Would it be useful to have a configuration per port? Agreed to one configuration parameter (for all ports) that will be ON by default. Want to keep port messages consistent. Many already include timestamps. The support for multiple ports is currently not implemented, only hooks are in place. Will revisit adding separate per port configurations when multi-port implementation is added.
    • #undef vs. #define. May be better to keep code consistent.
  • What is the default buffer size of a stdout message? Need to ensure the maximum length of a message that is output via port is sized to handle the new information that is on by default.
  • Snprintf code looks suspicious. The changes that will be applied to this ticket may resolve.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jphickey on 2017-10-20 11:45:00:

This is still marked for 6.6 but it appears to have gotten stale. We never merged the changeset associated with this.

In any case I would prefer to not propagate the current "output ports" implementation as it generally involves copying and pasting the same code 4 times with no benefit whatsoever. Lets fix #94 first and then the changeset for this one will be much easier and simpler.

I recommend deferring this to cfe-next.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-03 12:58:32:

Moved unfinished 6.7.0 tickets to next release

@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper removed this from the 6.8.0 milestone Nov 4, 2019
skliper added a commit to skliper/cFE that referenced this issue Apr 27, 2023
dzbaker added a commit that referenced this issue Apr 28, 2023
Fix #219, #93, Add EVS port timestamp and simplify port selection
@dzbaker dzbaker added this to the Equuleus milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants