Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Improvements for SB Transmit and Receive APIs #2460

Open
dzbaker opened this issue Oct 26, 2023 · 3 comments
Open

Performance Improvements for SB Transmit and Receive APIs #2460

dzbaker opened this issue Oct 26, 2023 · 3 comments

Comments

@dzbaker
Copy link
Collaborator

dzbaker commented Oct 26, 2023

Is your feature request related to a problem? Please describe.
The SB Transmit and Receive APIs tend to be the biggest performance bottleneck on a mission.

Describe the solution you'd like
Consider restoring the previous locking strategy.

Additional context
From RST:
SB Transmit and Receive APIs are generally the largest performance bottlenecks on mission. Changes in cFS since previous flight heritage missions have significantly decreased performance due to additional SB Lock calls (implemented to improve the modularity of the code, but without consideration for performance impacts).

Restoring the earlier Locking strategy reduces overall Spacecraft C&DH FSW utilization by 8.7% under nominal conditions, but could potentially be even greater once all subsystems are present.

Requester Info
Kequan Luu/NASA GSFC Code 582

@dzbaker
Copy link
Collaborator Author

dzbaker commented Oct 26, 2023

CCB 26 October 2023: Corwin will reach out to Kequan to identify which change specifically this is referring to.

@dmknutsen
Copy link
Contributor

@dzbaker Kequan may be referring to Fix #2381

It was not merged due to potential downstream impacts on performance. We are still setting up the lab to better characterize performance impacts on flight like targets. There are multiple pull requests on hold until further performance characterization can be completed.

@avan989
Copy link
Contributor

avan989 commented Oct 20, 2024

@chillfig @dzbaker @dmknutsen #2381 was merged. We need to close the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants