Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate / remove network_includes.h? #260

Closed
skliper opened this issue Sep 30, 2019 · 2 comments · Fixed by #1067 or #1088
Closed

Deprecate / remove network_includes.h? #260

skliper opened this issue Sep 30, 2019 · 2 comments · Fixed by #1067 or #1088
Labels
deprecate enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

network_includes.h seems to be a strange file to have in the executive. Nothing else in cFE uses it, and it is the only file in the core (non stub) code to test the various _OS_ macros (_LINUX_OS_, _MAC_OS_, etc.).

Should this file continue to exist as part of cFE? Or can it be deprecated and eventually removed? Apps that use it could keep their own copy as needed.
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 229. Created by tflemin1 on 2018-01-09T12:03:21, last modified: 2019-03-01T15:27:58

@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper added enhancement and removed bug labels Nov 4, 2019
@skliper
Copy link
Contributor Author

skliper commented Nov 4, 2019

Apps really should use OSAL APIs for the network logic. Opened the following tickets in ci_lab and to_lab that would need to be resolved first:

nasa/ci_lab#23
nasa/to_lab#15

skliper added a commit to skliper/cFE that referenced this issue Jan 6, 2021
@skliper
Fix nasa#260, Remove unused network_includes.h
d3e1cec
@skliper skliper mentioned this issue Jan 6, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Jan 6, 2021
astrogeco added a commit that referenced this issue Jan 12, 2021
@astrogeco
Merge pull request #1067 from skliper/fix260-rm_network_includes
fb18780 
Fix #260, Remove unused network_includes.h
@astrogeco astrogeco mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecate enhancement
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco