Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document CFE_ES_WriteToSysLog() can be used when CFE_ES_RegisterApp() fails #267

Closed
skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #566
Closed

Document CFE_ES_WriteToSysLog() can be used when CFE_ES_RegisterApp() fails #267

skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #566
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

On Thu, Apr 26, 2018 at 5:11 PM, Fleming, Thadeus thadeus.fleming@odysseysr.com wrote:
It's clear that CFE_ES_RegisterApp is supposed to be the first CFE
function an app calls, and that the app shouldn't continue if the call
fails.

However, it's not clear whether it's kosher to call
CFE_ES_WriteToSysLog to log failure of CFE_ES_RegisterApp. It appears
to be both safe (the function source doesn't look at the app's entry
in the AppTable) and common practice (e.g. the gen_app_code app
template does it).

I'd suggest that apps be allowed to call WriteToSysLog when
RegisterApp fails, and that the practice is documented so that future
versions of cFE don't modify WriteToSysLog in such a way that it would
become a problem.

@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 236. Created by dcmccom3 on 2018-04-27T12:16:34, last modified: 2019-03-24T16:45:53

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-03-24 16:45:53:

Could relate to #237

@skliper skliper removed their assignment Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Feb 26, 2020

Sounds like the resolution should also include a requirement (and part of build verification) or at maybe a functional test that shows an syslog can be used outside of a registered app. Need to investigate path forward (may already be covered in a test?)

@skliper skliper self-assigned this Feb 26, 2020
lbleier-GSFC pushed a commit to lbleier-GSFC/cFE that referenced this issue Apr 6, 2020
@skliper skliper linked a pull request Sep 24, 2021 that will close this issue
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant