-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate CDS and generic/ram mempool code into single implementation #56
Comments
Imported from trac issue 25. Created by jphickey on 2015-01-21T13:33:26, last modified: 2019-03-01T15:27:58 |
Trac comment by jphickey on 2015-05-19 09:39:35: This is an old enhancement that is yet to be merged in. Higher priority items taking precedence right now. |
With recent addition of a generic (offset-based) memory pool implementation that works with the abstract resource IDs in #917. I have also tested that this works for CDS blocks too. Discussed at 2020-09-30 CCB that this would be a good time to finally do this and make one mempool implementation. |
Rather than having a second pool implementation only for CDS, use the generic pool implementation. This also uses the abstract resource identifiers to identify CDS blocks, rather than a direct reference.
Rather than having a second pool implementation only for CDS, use the generic pool implementation. This also uses the abstract resource identifiers to identify CDS blocks, rather than a direct reference.
Fix #56, Refactor CDS to use generic pool implementation
Currently there are two memory pool implementations in ES:
These two are very similar except that the CDS uses offsets rather than direct pointers, and it calls into the PSP to perform actual read/write functions. It would not be very hard to consolidate these into a single implementation.
Each implementation consumes about 4-5kB of code/data space so this consolidation would make ES a little smaller in addition to making it cleaner.
The text was updated successfully, but these errors were encountered: