Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OMIT Deprecated flags with cFS codename instead of cFE version #803

Closed
astrogeco opened this issue Aug 14, 2020 · 3 comments
Closed
Labels

Comments

@astrogeco
Copy link
Contributor

astrogeco commented Aug 14, 2020

Is your feature request related to a problem? Please describe.
Nomenclature for deprecation can be confusing

Describe the solution you'd like
Create new deprecated flag for Bootes and maybe replace the deprecate 6_7 with deprecate Aquila

Describe alternatives you've considered
Keeping the current nomenclature

Additional context
Originally suggested in #784

does DEPRECATE_6_8 means that 6.8 was the last version which supports this function?

Yes, that is the paradigm we've been using up to this point -- the number reflects the last release were it was not deprecated. The idea of putting a version number in the tag was so we'd know which ones had "aged out" in a future release and should be taken out completely.

However as I mentioned before now that we have a codename for API compatibility then maybe we should consider using that instead.

Originally posted by @jphickey in #784 (comment)

Requester Info
Gerardo E. Cruz-Ortiz, NASA-GSFC

@skliper
Copy link
Contributor

skliper commented Aug 14, 2020

Might not be worth changing the old 6_7 over since that code can all be removed any time in this cycle.

@jphickey
Copy link
Contributor

See PR #817 -- removes all currently deprecated code blocks.

Probably don't really need to do anything - just come up with a codename-based convention for future deprecated blocks.

@skliper
Copy link
Contributor

skliper commented Sep 9, 2020

Per the most recent versioning discussion - all the current deprecated code will be removed (or has been) as part of this major release development cycle. Going forward the deprecate flags will not include a version number (like the osal model), or the codename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants