Fix #815, remove all deprecated code #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
added
the
CCB:Ready
skliper
approved these changes
Aug 18, 2020
|
CCB 2020-08-19 APPROVED. Needs more conversation about deprecation timeline and convention for cFS-Caelum |
|
@astrogeco - I thought we approved this one? Further discussion required on the topic of removing elements deprecated this cycle before the release of Caelum. |
Fixed CCB comment to reflect approval. |
astrogeco
added
CCB:Approved
|
@jphickey could you please resolve the conflicts here? |
In the next major CFE release, this code will be no longer supported at all. It should be removed early in the cycle to avoid needing to maintain this compatibility code.
jphickey
force-pushed
the
fix-815-remove-deprecated
branch
from
dbf3652 to
37a5ac9
Compare
|
Rebased. Note that this now includes several blocks with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
In the next major CFE release, this code will be no longer supported at all. It should be removed early in the cycle
to avoid needing to maintain this compatibility code.
Fixes #815
Testing performed
Build and run, sanity check CFE.
Run all unit tests.
Expected behavior changes
Removes code previously deprecated.
Identical to previous build if the
OMIT_DEPRECATED=trueflag was set during configuration.System(s) tested on
Ubuntu 20.04
RTEMS 4.11.3
Additional context
Also depends on nasa/to_lab#55 - should be merged in same cycle.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.