Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVS coverage test fails when CFE_PLATFORM_EVS_DEFAULT_TYPE_FLAG is set to 0xF #954

Closed
skliper opened this issue Oct 16, 2020 · 1 comment · Fixed by #1106 or #1109
Closed

EVS coverage test fails when CFE_PLATFORM_EVS_DEFAULT_TYPE_FLAG is set to 0xF #954

skliper opened this issue Oct 16, 2020 · 1 comment · Fixed by #1106 or #1109

Comments

@skliper
Copy link
Contributor

skliper commented Oct 16, 2020

Describe the bug
When CFE_PLATFORM_EVS_DEFAULT_TYPE_FLAG is set to 0xF there are two failures:

[ FAIL] 14.001 evs_UT.c:2675 - CFE_EVS_WriteLogDataFileCmd - Write log data - successful
[ FAIL] 14.002 evs_UT.c:2685 - CFE_EVS_SetLogModeCmd - Set logging mode - successful

To Reproduce
Steps to reproduce the behavior:

  1. Set CFE_PLATFORM_EVS_DEFAULT_TYPE_FLAG to 0xF
  2. Build unit tests, run cfe-core_evs_UT, observe failure

Expected behavior
Test should pass with debug events enabled (shouldn't care).

Code snips

/* Test successful log data file write */
UT_InitData();
UT_EVS_DoDispatchCheckEvents(&PktBuf.writelogdatacmd, sizeof(PktBuf.writelogdatacmd),
UT_TPID_CFE_EVS_CMD_WRITE_LOG_DATA_FILE_CC,
&UT_EVS_EventBuf);
UT_Report(__FILE__, __LINE__,
UT_EVS_EventBuf.EventID == 0xFFFF,
"CFE_EVS_WriteLogDataFileCmd",
"Write log data - successful");
/* Test successfully setting the logging mode */
UT_InitData();
UT_EVS_DoDispatchCheckEvents(&PktBuf.modecmd, sizeof(PktBuf.modecmd),
UT_TPID_CFE_EVS_CMD_SET_LOG_MODE_CC,
&UT_EVS_EventBuf);
UT_Report(__FILE__, __LINE__,
UT_EVS_EventBuf.EventID == 0xFFFF,
"CFE_EVS_SetLogModeCmd",
"Set logging mode - successful");

System observed on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: 6.8.0-rc1+dev129

Additional context
N/A

Reporter Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Oct 16, 2020

I haven't dug into the logic, but I suspect it's considering no events a success. This doesn't seem very resilient, check should be that the dispatch logic was followed as expected not zero events. If all events were disabled, this would always pass.

skliper added a commit to skliper/cFE that referenced this issue Jan 19, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 19, 2021
@astrogeco astrogeco added the bug label Jan 21, 2021
astrogeco added a commit that referenced this issue Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants