Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #945, Finish CFE_PLATFORM_ES_PERF_MAX_IDS removal #1104

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 19, 2021

Describe the contribution
Fix #945 - Removes the rest of the references/uses of CFE_PLATFORM_ES_PERF_MAX_IDS (in favor of CFE_MISSION_ES_PERF_MAX_IDS )

Testing performed
Build and run unit tests, passed

Expected behavior changes
None, just avoids issues that could happen if the platform/mission defines diverged

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
#1103 is open for consideration, but future work

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 19, 2021
@skliper skliper added this to the 7.0.0 milestone Jan 19, 2021
@astrogeco
Copy link
Contributor

CCB:2021-01-21 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate January 25, 2021 03:38
@astrogeco astrogeco added CCB:2021-01-21 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 25, 2021
@astrogeco astrogeco merged commit cc514bc into nasa:integration-candidate Jan 25, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 25, 2021
@skliper skliper deleted the fix945-platform_perf_max_id branch February 1, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_PLATFORM_ES_PERF_MAX_IDS not fully deprecated
2 participants