Fix #1435, Consistent use of uint16 for EventID #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
the
CCB:Ready
skliper
force-pushed
the
fix1435-eventid_type
branch
from
d685d0e to
d7c2b24
Compare
This was referenced May 25, 2021
jphickey
approved these changes
May 26, 2021
skliper
added
the
CCB:Approved
astrogeco
removed
the
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1435 - use
uint16everywhere forEventIDTesting performed
Built/ran unit tests, passed
Expected behavior changes
None, just makes types consistent
System(s) tested on
Additional context
Doesn't fix the fact CFE_EVS_FREE_SLOT is not documented or handled well. See #1574.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC