cFE Integration candidate: Equuleus-rc1+dev7 #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CFE_ES_CreateChildTask to propagate the user-supplied stack pointer to the underlying OS_TaskCreate call. Also adds a functional test to check that the memory address of a local variable within a child task resides within the expected stack buffer. NOTE: this requires an additional fix to POSIX OSAL to make it work on that platform.
Fix #2516, propagate stack pointer for child tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| CFE_ES_ExitChildTask(); | ||
| } | ||
|
|
||
| void TestCreateChildWithStack(void) |
Check notice
Code scanning / CodeQL
Long function without assertion Note test
| #define UT_LOCAL_STACK_SIZE 4096 | ||
| static unsigned long UT_LOCAL_STACK[UT_LOCAL_STACK_SIZE]; | ||
|
|
||
| void TestCheckStackPointer(void) |
Check notice
Code scanning / CodeQL
Long function without assertion Note test
| * NOTE: The custom stack does not work on RTEMS, test is disabled on that platform | ||
| * for the time being (custom stack may be deprecated in future CFE release). | ||
| */ | ||
| #ifndef _RTEMS_OS_ |
Check notice
Code scanning / CodeQL
Conditional compilation Note test
Correct two cases where struct variables on the stack were not being properly cleared before use.
2 tasks
Hotfix #2526, add missing memset() for stack variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
cFS Bundle Checks
cFE Checks
Expected behavior changes
See PRs
System(s) tested on
Ubuntu 20.04
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey