Fix #374: CFE_ES_GetTaskInfo must be passed a task ID

[jphickey]

Fix 2 areas where the CFE_ES_GetTaskInfo() function could
have been passed an App ID rather than a task ID, which
would create an incorrect result and generate an error in the syslog

Testing performed
Steps taken to test the contribution:

• Set EVS default configuration to enable all events (including DEBUG) by default
• Built all for pc-linux from a clean slate
• Run CFE core and confirm all startup OK
• Externally Issue StopApp command for "SAMPLE_APP"
• Confirmed that all debug events are correct
• Confirmed that the original error is not generated
• Externally Issue Shell command for "ES_ListTasks"
• Confirmed that no bad task ID errors are shown
• Confirmed that the file output is correct

Expected behavior changes
The invalid task errors shown in the logs prior to this change are NOT generated after this change.

System(s) tested on:
Ubuntu 18.04.2 LTS 64-bit

Contributor Info
Joseph Hickey, Vantage Systems, Inc.

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

[jphickey]

Additional notes:

Before this change, with full debug events enabled, issuing the StopApp command for SAMPLE_APP generated these events:

EVS Port1 42/1/CFE_SB 48: Subscription Removed:Msg 0x127 on pipe 5,app CFE_ES
EVS Port1 42/1/CFE_SB 48: Subscription Removed:Msg 0x129 on pipe 5,app CFE_ES
1980-012-14:15:42.50072 CFE_ES_GetTaskInfo: Task ID Not Valid: 5
EVS Port1 42/1/CFE_SB 47: Pipe Deleted:id 5,owner Unknown
EVS Port1 42/1/CFE_ES 14: Exit Application SAMPLE_APP on Error Completed.

After this change, the same command generates these events:

EVS Port1 42/1/CFE_SB 48: Subscription Removed:Msg 0x127 on pipe 5,app CFE_ES
EVS Port1 42/1/CFE_SB 48: Subscription Removed:Msg 0x129 on pipe 5,app CFE_ES
EVS Port1 42/1/CFE_SB 47: Pipe Deleted:id 5,owner SAMPLE_APP
EVS Port1 42/1/CFE_ES 14: Exit Application SAMPLE_APP on Error Completed.

[stashakk]

MSFC approved

[CDKnightNASA]

ARC approved

[skliper]

CCB 20191023 - reviewed and approved

[skliper]

Fixes #374, wasn't listed in pull request so didn't originally show up as a link.