-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SRC_LOCAL_PATH as single source of truth #458
Conversation
This avoids the two path diverging and possibly causing problems in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
CLA confirmed, this pull request can proceed. |
@matzipan and @stanislaw please update the the title of your pull requests and your commits to use the following format:
see other pull requests and commits in repository as an example. |
CCB 20200311 - Approved |
Apologies for not having time to change the title format to |
No worries. We don't have a contribution guide up so you had no way to know in advance. In the future please open an issue and then the pull request to address it; this helps us build our version description document when we do our next release. |
This avoids the two path diverging and possibly causing problems in the future
Describe the contribution
The call to
file(TO_NATIVE_PATH ...)
is building its own path even though its contents are identical toSRC_LOCAL_PATH
. This change avoids possible divergence of these values in the future.Testing performed
Ran a local build.
Expected behavior changes
No change in behavior.