-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #766, Add to table search path #767
Fix #766, Add to table search path #767
Conversation
@jphickey @astrogeco could we add this one in? stakeholder request. Ping @excaliburtb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this, it's simple enough and shouldn't break anything.
Once PR #751 is merged then I'd suggest adding a table search path to mission_defaults.cmake to allow customization of this table search path. It is a little more complicated than the app search path as it needs to be per-cpu but I think it can be done.
The table search path in mission_defaults.cmake would be the ideal solution in my mind. I really think moving the various search paths to mission_defaults.cmake is a significant improvement in general. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of ${TGT}/ as it is easier to create addl. cpu's without having to spend time renaming long filenames that start with ${TGT}_.
Are you waiting on me for anything? I'd like to get this in to at least IC branch and the solution looks fine to me. |
Whoops, I thought this was in IC... @astrogeco could we get this added? |
Describe the contribution
Adds to table search path
Fix #766
Testing performed
CI
Expected behavior changes
Just adds to search path
System(s) tested on
CI
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC