Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #766, Add to table search path #767

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 1, 2020

Describe the contribution
Adds to table search path
Fix #766

Testing performed
CI

Expected behavior changes
Just adds to search path

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Jul 1, 2020

@jphickey @astrogeco could we add this one in? stakeholder request.

Ping @excaliburtb

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, it's simple enough and shouldn't break anything.

Once PR #751 is merged then I'd suggest adding a table search path to mission_defaults.cmake to allow customization of this table search path. It is a little more complicated than the app search path as it needs to be per-cpu but I think it can be done.

@skliper
Copy link
Contributor Author

skliper commented Jul 1, 2020

Once PR #751 is merged then I'd suggest adding a table search path to mission_defaults.cmake to allow customization of this table search path. It is a little more complicated than the app search path as it needs to be per-cpu but I think it can be done.

The table search path in mission_defaults.cmake would be the ideal solution in my mind. I really think moving the various search paths to mission_defaults.cmake is a significant improvement in general.

Copy link
Contributor

@CDKnightNASA CDKnightNASA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of ${TGT}/ as it is easier to create addl. cpu's without having to spend time renaming long filenames that start with ${TGT}_.

@excaliburtb
Copy link

Are you waiting on me for anything? I'd like to get this in to at least IC branch and the solution looks fine to me.

@skliper
Copy link
Contributor Author

skliper commented Jul 8, 2020

Whoops, I thought this was in IC... @astrogeco could we get this added?

@skliper skliper added the Priority: Mission Feature or bug related to stakeholder needs label Jul 8, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate July 8, 2020 13:21
@astrogeco astrogeco changed the title Fix 766, Add to table search path Fix #766, Add to table search path Jul 8, 2020
@astrogeco astrogeco merged commit 4bb29b7 into nasa:integration-candidate Jul 8, 2020
@skliper skliper deleted the fix766-add-table-path branch October 22, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:FastTrack enhancement Priority: Mission Feature or bug related to stakeholder needs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to table search path... either point solution or general
5 participants