Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate: 2020-09-29 #916

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Integration Candidate: 2020-09-29 #916

merged 3 commits into from
Sep 29, 2020

Conversation

yammajamma
Copy link
Contributor

@yammajamma yammajamma commented Sep 29, 2020

Describe the contribution
Fix #894

Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/144/checks

Expected behavior changes
PR #896 - Add a new typedef CFE_ES_ResourceID_t that can replace uint32 for all ID storage and manipulation. Initially this is just an alias to uint32 for backward compatibility.

System(s) tested on
Ubuntu - CI

Additional context
nasa/cFS#144

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

jphickey and others added 2 commits September 22, 2020 13:54
Add a new typedef "CFE_ES_ResourceID_t" that can
replace uint32 for all ID storage and manipulation.
Initially this is just an alias to uint32 for
backward compatibility.

Convert all APIs that accept an ID to use the new
typedef.

This also reserves the value "0" as an undefined ID,
and gives a separate base value for each resource type.
Therefore even though the type is still uint32, the
different resource IDs can still be distingushed.
@yammajamma yammajamma merged commit 8a7dc8f into main Sep 29, 2020
yammajamma added a commit to nasa/cFS that referenced this pull request Sep 29, 2020
yammajamma added a commit to nasa/cFS that referenced this pull request Sep 29, 2020
* IC: 20200929: Updating submodules to main.

Integration Candidate includes:
nasa/cFE#916
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typedef and nonzero base for resource identifiers
3 participants