Adding Python 3 compatibility #35 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated GroundSystem.py and RoutingService.py scripts needed to upgrade to Python 3.
skliper
approved these changes
Dec 17, 2019
|
CCB 20191218 - Reviewed and approved for IC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated GroundSystem.py and RoutingService.py scripts needed to upgrade to Python 3.
Describe the contribution
Fixes issue #35
Testing performed
Steps taken to test the contribution:
Build steps:
a. Need to install Python 3 (if not already installed)
b. May need to install zmq and pyqt4 for python3
- sudo apt-get install python3-zmq
- sudo apt-get install python3-pyqt4
Execution steps:
To run type - python3 GroundSystem.py
Expected behavior changes
No behavior changes are expected. However there was an additional unreported issue with the commanding interface - where upon startup it would intermittently issue the following error - "Ignored socket error" resulting in the inability to command. This issue was also fixed when updating the scripts.
System(s) tested on:
Additional context
NA
Contributor Info
Dan Knutsen
NASA Goddard Space Flight Center
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted