Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main user guide build warnings (and they weren't caught by actions) #167

Closed
skliper opened this issue Jan 4, 2021 · 0 comments · Fixed by #168 or #172
Closed

Main user guide build warnings (and they weren't caught by actions) #167

skliper opened this issue Jan 4, 2021 · 0 comments · Fixed by #168 or #172
Labels
bug continuous-integration

Comments

@skliper
Copy link
Contributor

skliper commented Jan 4, 2021

Describe the bug
Warnings generated when building user's guide

To Reproduce
I did standard setup, and make SIMULATION=native prep but likely exists for any config.
Then make usersguide, observe warnings in build/doc/warnings.log:

/export/home/jhageman/cFS/cFS-GitHub/osal/src/os/inc/osapi-bsp.h:95: warning: end of file while inside a group
/export/home/jhageman/cFS/cFS-GitHub/osal/src/os/inc/osapi-idmap.h:274: warning: end of file while inside a group

Expected behavior
No warnings.
Also the new GitHub actions should have caught this. @astrogeco

Note the warnings file at https://github.com/nasa/cFS/suites/1693812098/artifacts/31817568 is not empty... not clear why this didn't trigger a failure.

Code snips
None yet.

System observed on:

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main

Additional context
N/A

Reporter Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the bug label Jan 4, 2021
skliper added a commit to skliper/cFS that referenced this issue Jan 4, 2021
@skliper
Fix nasa#167, Update doc generation action error check
64ca797 
Warning file is moved in Build Usersguide step.
Updated from checking the old file location to
checking the moved file.
@skliper skliper mentioned this issue Jan 4, 2021
Merged
astrogeco added a commit to astrogeco/cFS that referenced this issue Jan 4, 2021
@astrogeco
Fix nasa#167, add cppcheck step
3af1285
astrogeco added a commit to astrogeco/cFS that referenced this issue Jan 4, 2021
@astrogeco
Fix nasa#167, Add static analysis to CI workflow
bd7f5a5
astrogeco added a commit that referenced this issue Jan 5, 2021
@astrogeco
Merge pull request #168 from skliper/fix167-error_on_doc_warnings
57c78c7 
Fix #167, Update doc generation action error check
@astrogeco astrogeco mentioned this issue Jan 6, 2021
Merged
chillfig pushed a commit to chillfig/cFS that referenced this issue Mar 17, 2022
@astrogeco
Merge pull request nasa#167 from jphickey/fix-125-cmd-counts
1d9719b 
Fix nasa#125, correct accept/reject counter increments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug continuous-integration
Projects
None yet
Milestone
No milestone
2 participants
@skliper @astrogeco