Fix #166 and #169, Add Static Code Analysis and Pull Request Trigger to CI workflow #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set fail-fast to false for all workflows Clean up comments
astrogeco
force-pushed
the
fix-167-and-169-cppcheck-and-pr-workflow
branch
from
b3ed26a to
d1093f8
Compare
skliper
approved these changes
Jan 4, 2021
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Use the correct typedef for OSAL ID. This also necessiates using the correct conversion macro where use as an integer is intended.
chillfig
pushed a commit
to chillfig/cFS
that referenced
this pull request
Mar 17, 2022
Fix nasa#171, use osal_id_t for OSAL ID, not int32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #166
Fix #169
Testing performed
Succesfully ran in fork.
Also see pull-request trigger working at https://github.com/nasa/cFS/pull/171/checks
Expected behavior changes
New workflow "Static Analysis" runs cpp check on the bundle and also stricter checks on cfe, osal, and psp based on the old travis.yml setups.
System(s) tested on
Ubuntu 18.04
Additional context
None