Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI_LAB should put all global variables into a global structure #36

Closed
jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #35 or #38
Closed

CI_LAB should put all global variables into a global structure #36

jphickey opened this issue Feb 7, 2020 · 0 comments · Fixed by #35 or #38
Assignees
@jphickey
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented Feb 7, 2020

Is your feature request related to a problem? Please describe.
CI_LAB has several global variables, which are inconsistently named. Most have a CI prefix but the prefix should at least be CI_LAB to match the module name.

Describe the solution you'd like
All globals should all be put into a single top-level global structure, similar to the way other modules isolate their global variables. This consolidates everything and also provides namespace protection.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Feb 7, 2020
jphickey added a commit to jphickey/ci_lab that referenced this issue Feb 8, 2020
@jphickey
Fix nasa#36: Add CI_LAB namespace to all identifiers
655f025 
Add a global structure called "CI_LAB_Global" for all globals, getting
them out of the global namespace.  All other identifiers that remain
in the global namespace should be prefixed consistently with CI_LAB_
to match the name of the app.
@jphickey jphickey linked a pull request Feb 8, 2020 that will close this issue
Multiple cleanup items for CI LAB #35
Merged
@jphickey jphickey mentioned this issue Feb 8, 2020
Merged
astrogeco pushed a commit that referenced this issue Mar 9, 2020
@jphickey
Fix #36: Add CI_LAB namespace to all identifiers
a9c51f1 
Add a global structure called "CI_LAB_Global" for all globals, getting
them out of the global namespace.  All other identifiers that remain
in the global namespace should be prefixed consistently with CI_LAB_
to match the name of the app.
@astrogeco astrogeco mentioned this issue Mar 10, 2020
Merged
@astrogeco astrogeco linked a pull request Mar 10, 2020 that will close this issue
IC 20200304 #38
Merged
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
@astrogeco astrogeco added the enhancement New feature or request label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Multiple cleanup items for CI LAB jphickey/ci_lab
IC 20200304 nasa/ci_lab
2 participants
@jphickey @astrogeco