Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #71, Add CodeQL analysis to workflow #72

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Feb 5, 2021

Describe the contribution
Fix #71 - adds CodeQL analysis

Differences from bundle - path theoretically limited to ci_lab, has timeout, and "security and quality", and only does the build (run not necessary for codeql analysis)

Testing performed
Ran on fork

Expected behavior changes
Adds Code QL analysis on push to main and pull requests (to main)

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Feb 5, 2021
@skliper skliper added this to the 2.5.0 milestone Feb 5, 2021
@skliper skliper removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 5, 2021
@ArielSAdamsNASA
Copy link
Contributor

For some reason there is one warning presented in the workflow:

1 issue was detected with this workflow: Please make sure that every branch in on.pull_request is also in on.push so that Code Scanning can compare pull requests against the state of the base branch.

Also when viewing the code scanning results, it shows results outside of the ci_lab path as seen below. For example, it shows errors for osal.
image

@skliper
Copy link
Contributor Author

skliper commented Feb 8, 2021

@ArielSAdamsNASA I'm wondering if the error is because the analysis hasn't been run in main yet. I tried runs on all branches for push/pull and saw the same warning. Maybe it will go away? For OSAL results - I'm not seeing the same thing. Shows up as "This branch hasn't been scanned yet" for me on nasa/ci_lab main branch. Which branch were you on?

@ArielSAdamsNASA
Copy link
Contributor

For OSAL results - I'm not seeing the same thing. Shows up as "This branch hasn't been scanned yet" for me on nasa/ci_lab main branch. Which branch were you on?

I was also on the nasa/ci_lab main branch. I ran the analysis again this morning and noticed that the OSAL results now have "(Test)" in the title. As long as it works locally for you, it should perform the same once implemented.

image

@skliper
Copy link
Contributor Author

skliper commented Feb 8, 2021

@ArielSAdamsNASA Now I'm seeing the warnings... seems I have the path exclusions set up incorrectly, I'll try to fix!

@skliper skliper marked this pull request as draft February 8, 2021 18:15
@ArielSAdamsNASA ArielSAdamsNASA self-requested a review February 8, 2021 18:33
@skliper skliper force-pushed the fix71-add_codeql branch 5 times, most recently from de778fd to 5793160 Compare February 8, 2021 19:11
@skliper skliper marked this pull request as ready for review February 8, 2021 19:14
@skliper
Copy link
Contributor Author

skliper commented Feb 8, 2021

Updates - made it only build ci (so it only reports CI errors), also embedded queries in workflow instead of separate config file

@astrogeco astrogeco added continuous-integration enhancement New feature or request and removed enhancement New feature or request labels Feb 12, 2021
@astrogeco astrogeco merged commit 296d12c into nasa:main Feb 12, 2021
@skliper skliper deleted the fix71-add_codeql branch April 1, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeQL analysis to workflow
3 participants