Jk/cumulus 3701 fix null rules (#3641) #3645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update core deps to v20.12.2 * Update unit test to rmove .sort .sort is intermittently failing to order as expected, causing this test to fail in local test at an alarming failure rate. Updating test to be more explicit/remove sort, however this needs to be investigated prior to closing thie branch/PR/ticket * Update kinesis test to node v20 JSON.parse now throws a different error for the merged test case. * Update knex test to handle new subdependency throwing an Aggregate error * Revert "Update unit test to rmove .sort" This reverts commit adbad84. * Update got * Revert "Update got" This reverts commit a19f9d1. * Upgrade ava/nock, fix ingest provider tests * Reapply "Update got" This reverts commit e652516. * Update ingest module for node 20 This update has a couple of controversial changes in it: Updating got to v14 means we're using a pure ESM module given sindre's stance on not supporting common exports. That's being done due to incompatible changes in node streams requires at least got v12 Additionally there's a probable outstanding issue in got sindresorhus/got#2341 related to node v20/fs readstreams/nock and/or msw incompatibility (as well as a possible open source contrib) * Remove httpClient test mock/fix Updating the existing apache server to return 200 on an existing endpoint is far better than the prior commit approach in that it's a valid/useful unit test as a result, with the technical/less tidy downside of requiring the unit test stack to be working. * Update local test stack configuration to restrict connection to localhost * Update send-pan test/dependencies * Update lambdas/async operation to deploy with node 20 * Update common to export a helper to import ESM got module * Add docstring to importGot * Remove unneeded imports * Minor PR review fixes * Update CHANGELOG * Update CHANGELOG * Reconfigure CI to not use unsafe perms modification * Fix broken package.json * Fix extran. dep issue * Make error message test less specific * Update test to not rely on aggregate internal errors * Update packages/ingest/test/test-HttpProviderClient.js Co-authored-by: etcart <37375117+etcart@users.noreply.github.com> * Move importGot -> importEsm, introduce static import definition * Fix inadvertant test commit * Update rules helpers to remove all null key values from rule JSON * Update CHANGELOG * Update helper test titles for consistency * Minor refactor/rename * Fix typing errors in original code, update PR accordingly * Fix inadvertant move of rule validation * Update packages/api/endpoints/rules.js Co-authored-by: etcart <37375117+etcart@users.noreply.github.com> * Remove custom null removal method in favor of omitDeepBy * Remove duplicative call to omitDeepBy * Update packages/api/lib/rulesHelpers.js Co-authored-by: etcart <37375117+etcart@users.noreply.github.com> --------- Co-authored-by: etcart <37375117+etcart@users.noreply.github.com>
npauzenga
requested changes
May 7, 2024
|
@npauzenga I believe that should be part of the release 18.2.x ticket |
npauzenga
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-3701
Changes
PR Checklist