Jk/cumulus 3020 #3800
Open
Jk/cumulus 3020 #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npauzenga
requested changes
Sep 20, 2024
| variable "sf_event_sqs_lambda_timeout" { | ||
| type = number | ||
| default = null | ||
| description = "A timeout override for the sf_event_sqs_to_db_records lambda. Defaults to (var.rds_connection_timing_configuration.acquireTimeoutMillis / 1000) + 60). Use with caution, system instability may result if modified" |
There was a problem hiding this comment.
Could we specify that the unit is milliseconds? Assuming that's correct 😄
| variable "sf_event_sqs_lambda_timeout" { | ||
| type = number | ||
| default = null | ||
| description = "A timeout override for the sf_event_sqs_to_db_records lambda. Defaults to (var.rds_connection_timing_configuration.acquireTimeoutMillis / 1000) + 60). Use with caution, system instability may result if modified" |
| # between the IAM role, queue and lambda function. | ||
| sf_event_sqs_lambda_timeout = (var.rds_connection_timing_configuration.acquireTimeoutMillis / 1000) + 60 | ||
| # between the IAM role, queue, and lambda function. | ||
| sf_event_sqs_lambda_timeout = var.sf_event_sqs_lambda_timeout != null ? var.sf_event_sqs_lambda_timeout : (var.rds_connection_timing_configuration.acquireTimeoutMillis / 1000) + 60 |
There was a problem hiding this comment.
I paused on the explicit comparison to null but that's the default so seems fine. I don't see how this would be undefined.
| @@ -23,6 +23,7 @@ module "archive" { | |||
| elasticsearch_security_group_id = var.elasticsearch_security_group_id | |||
| elasticsearch_remove_index_alias_conflict = var.elasticsearch_remove_index_alias_conflict | |||
|
|
|||
| sf_event_sqs_lambda_timeout = var.sf_event_sqs_lambda_timeout | |||
There was a problem hiding this comment.
Should we update the example terraform? I always ask this and the answer is usually "it's not intended to exemplify all possible options". I think it's fine not to, just raising it for kicks.
There was a problem hiding this comment.
The main benefit as I see it would just be documentation if users are looking at the example config. It's probably best to have it well documented in the variables tf like you have it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-3020
PR Checklist