Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cumulus versions due to bad merge #3826

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

npauzenga
Copy link
Contributor

I'm not 100% sure which merge caused this but it appears that the Cumulus version v19.0.0 was overwritten on main with a previous version for the aws-client package. This breaks bootstrap.

@npauzenga
Copy link
Contributor Author

"@aws-sdk/client-kinesis": "^3.447.0",
"@aws-sdk/client-kms": "^3.447.0",
"@aws-sdk/client-lambda": "^3.529.1",
"@aws-sdk/client-s3": "^3.447.0 <3.614.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are newer changes to avoid a vulnerability or something, this may be wrong. We'll see what CI says.

Copy link
Contributor

@jennyhliu jennyhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npauzenga npauzenga merged commit edb9f7b into master Oct 15, 2024
3 checks passed
@npauzenga npauzenga deleted the fix-aws-client-versions branch October 15, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants