Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUMULUS-3931: Allowing force_new_deployment to be configurable for ecs services. #3838

Merged
merged 3 commits into from
Oct 24, 2024
Merged

CUMULUS-3931: Allowing force_new_deployment to be configurable for ecs services. #3838

merged 3 commits into from
Oct 24, 2024

Conversation

Jkovarik
Copy link
Member

@Jkovarik Jkovarik commented Oct 24, 2024 •
edited
Loading

Summary: Summary of changes

Addresses CUMULUS-3931

Changes

  • Adds force_new_deployment configuration to the ecs_service to force redeploy on update

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@Jkovarik
Copy link
Member Author

Bringing in #3835

@Jkovarik Jkovarik mentioned this pull request Oct 24, 2024
Closed
4 tasks
@Jkovarik Jkovarik added needs review User Contribution Very Small Look at this one because it's very easy. labels Oct 24, 2024
@Jkovarik Jkovarik changed the title Allowing force_new_deployment to be configurable for ecs services. CUMULUS-3931: Allowing force_new_deployment to be configurable for ecs services. Oct 24, 2024
@Jkovarik
Copy link
Member Author

Added changelog, up for review. Thanks @Michaellh0079 for the contrib! 🎉

npauzenga
npauzenga approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@npauzenga npauzenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can't see a reason not to provide this. I don't think there's much value in including it in the example deployment either so 👍

@Jkovarik
Copy link
Member Author

@Michaellh0079 this has been merged and will go out with the next forward release. Thanks again.

@Jkovarik Jkovarik merged commit d1e0311 into master Oct 24, 2024
3 checks passed
@Jkovarik Jkovarik deleted the mlh0079-ghrccloud-6780-force-new-deployment branch October 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npauzenga npauzenga npauzenga approved these changes

Assignees
No one assigned
Labels
User Contribution Very Small Look at this one because it's very easy.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jkovarik @npauzenga @Michaellh0079