19.1.x with master #3847
Merged
19.1.x with master #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* version bump * Update CL * Update docs * Update CL link * Add note for clarity * update missed deps
* guarantee non-numeric nonNumericString * bringing in pg8.13 snyk suggestion * trying to kcik up the sync-granules task error * trying to get repeatable tries to sync-granules * focus on just the important part in syncgranule * trying to get publish to work * does only this need to change to import? * move to import function import * reverting bad code for testing reasons * changelog * keep string length the same, no reason to twiddle this Co-authored-by: etcart <37375117+etcart@users.noreply.github.com>
Jkovarik
reviewed
Oct 28, 2024
| @@ -8141,7 +8158,8 @@ Note: There was an issue publishing 1.12.0. Upgrade to 1.12.1. | |||
|
|
|||
| ## [v1.0.0] - 2018-02-23 | |||
|
|
|||
| [Unreleased]: https://github.com/nasa/cumulus/compare/v19.0.0...HEAD | |||
| [Unreleased]: https://github.com/nasa/cumulus/compare/v19.1.0...HEAD | |||
| [v19.1.0]: https://github.com/nasa/cumulus/compare/v19.0.0...v19.1.0 | |||
There was a problem hiding this comment.
Not blocking given the PR, but should we do something like 18.5->19.1 in the future given the migration path doesn't travel through 19.0?
There was a problem hiding this comment.
The stance I'm taking with v19 is that it exists but is deprecated. So the CL entry for 19.1 has:
This release contains changes listed here as well as changes listed in v19.0.0,
despite v19.0.0 being deprecated. Please review Changelog entries and Migration Notes for
each Cumulus version between your current version and v19.1.0 as normal.
My sense is that it would be more confusing to skip a version here an elsewhere. I could be wrong though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-XX: Develop amazing new feature
Changes
PR Checklist