CUMULUS-3847: Remove any remaining ES indexing functions and tests #3897
Conversation
…loud Metrics usage
| }); | ||
|
|
||
| test.serial('writePdr() saves a PDR record to PostgreSQL/Elasticsearch if PostgreSQL write is enabled', async (t) => { | ||
| test.serial('writePdr() saves a PDR record to PostgreSQL if PostgreSQL write is enabled', async (t) => { |
There was a problem hiding this comment.
I think we can remove if PostgreSQL write is enabled
There was a problem hiding this comment.
Maybe we can rename this file with different extension since we still want cleanExecution functionality, and will be updated in a different ticket.
There was a problem hiding this comment.
Suggest to comment out the code, and put a dummy handler, so the lambda can still be created in tf-modules/archive/clean_executions.tf
packages/api/lambdas/bootstrap.js
Outdated
| @@ -4,6 +4,7 @@ | |||
| * It helps: | |||
| * - adding ElasticSearch index mapping when a new index is created | |||
| */ | |||
| // is this needed for CloudMetrics? | |||
There was a problem hiding this comment.
With es instance going away, this lambda shouldn't be needed.
| @@ -188,6 +188,7 @@ test('ec2() service defaults to localstack in test mode', async (t) => { | |||
| ); | |||
| }); | |||
|
|
|||
| // can this test be removed or is it needed for the granule CloudMetrics queries? | |||
There was a problem hiding this comment.
With es instance going away, I think packages/aws-client/tests/services.js es and this test are not needed.
| @@ -969,6 +954,7 @@ async function handler(event) { | |||
| process.env.CMR_PAGE_SIZE = process.env.CMR_PAGE_SIZE || '200'; | |||
|
|
|||
| //TODO: Remove irrelevant env vars from terraform after ES reports are removed | |||
| // can this be changed now? | |||
There was a problem hiding this comment.
Yeah, we are not querying es anymore.
| @@ -49,7 +49,7 @@ const esSearchStub = sandbox.stub(); | |||
| const esScrollStub = sandbox.stub(); | |||
| FakeEsClient.prototype.scroll = esScrollStub; | |||
| FakeEsClient.prototype.search = esSearchStub; | |||
|
|
|||
| // is this es-client stuff still needed b/c granules and metrics? | |||
There was a problem hiding this comment.
I think es-client is still needed. You can try to take it out.
…d of full removal
…loud Metrics usage
Summary: Summary of changes
Addresses CUMULUS-3847: Remove any remaining ES indexing functions and tests
Changes
PR Checklist