Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph.py code cleaning #7

Merged
merged 2 commits into from
May 23, 2023
Merged

graph.py code cleaning #7

merged 2 commits into from
May 23, 2023

Conversation

louwersj
Copy link
Contributor

changes to graph.py to refactored code to become PEP8 compliant. Requires more work in a later stage, however a first step.

…quires more work in a later stage, however a first step.
Copy link
Collaborator

@hulsed hulsed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments where you listed documentation as "TODO," so add those to the documentation and I will merge in the PR.

fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
fmdtools/analyze/graph.py Show resolved Hide resolved
fmdtools/analyze/graph.py Show resolved Hide resolved
fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
fmdtools/analyze/graph.py Outdated Show resolved Hide resolved
- changes to graph.py to refactored code to become PEP8 compliant. Requires more work in a later stage, however a first step.
@louwersj
Copy link
Contributor Author

@hulsed taken all your comments into account and are now part of commit #2 of this pull request.

@hulsed hulsed merged commit ff389bd into nasa:main May 23, 2023
hulsed added a commit that referenced this pull request Jul 6, 2023
Merge in RAD/fmdtools from RAD-206-adapt-tank-example to 2.0-dev

* commit '1aca90739668e53742ee64ab46bb1e43c5b354e5': (26 commits)
  Formatting improvements for tank_model.py
  Fixing formatting errors identifed in the PR
  Regen asg_demo notebook and fixed bug
  Further changes:
  Fixed tank bug
  More revision of ASG
  More in-progress work
  Removed unneeded valve1_sig from Detect
  Adding some helpful things to Result
  Fixed bug in ASG copying
  in-progress bugfixing
  More tinkering
  More safety things
  Fixed ASG flow copy bug
  Some edits
  Fixed issues with get_args
  Refactoring for tank
  More test updates
  Fixing issues with tank model
  Fixing parallel execution options
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants