Fixing sanitizer handling. Fixes nasa/fprime#2678 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-bc
approved these changes
Nov 22, 2024
thomas-bc
reviewed
Nov 22, 2024
| @@ -57,11 +57,11 @@ def run_fbuild_cli( | |||
| toolchain = build.find_toolchain() | |||
| print(f"[INFO] Generating build directory at: {build.build_dir}") | |||
| print(f"[INFO] Using toolchain file {toolchain} for platform {parsed.platform}") | |||
| if parsed.ut and not parsed.disable_sanitizers: | |||
| if parsed.disable_sanitizers: | |||
There was a problem hiding this comment.
This line is the only place in the system (currently) where sanitizers do get enabled. Without it, sanitizers will always be disabled unless the ENABLE_SANITIZERS_* flags are passed to CMake.
Is this the intended behavior? It feels to me that sanitizers on UTs are a good practice.
Not sure why nasa/fprime#2678 fails though...
There was a problem hiding this comment.
Oh I should have read nasa/fprime#2678 prior to posting this lol
Are you intending to make a PR to F´ to have SANITIZERS_* = BUILD_TESTING
There was a problem hiding this comment.
My intent was to set sanitizers in CMake in F´, yes.
thomas-bc
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This fixes nasa/fprime#2678. Essentially, the presence of the disable sanitizer flag should disable the sanitizers. In other cases, the sanitizer handling should be left to the underlying fprime/CMake implementation.