Side-Effect Free Assetion Code

[LeStarch]

F´ Version
Affected Component

---

Problem Description

FW_NO_ASSERT reduces the FW_ASSERT macro to "", that is, it is compiled-out. However, this breaks assertions with side-effect inducing code (see example below).

We need to fix several things:

1. Clean up the fprime framework code to not depend on side-effects in FW_ASSERT calls
2. Make the default FW_NO_ASSERT option maintain side-effects
3. Add an option for power-users to return FW_NO_ASSERT to the completely removed case.
4. Update style guidelines to call this coding flaw out

Example offending code:

fprime/Svc/GenericHub/GenericHubComponentImpl.cpp

Line 169 in 6641547

FW_ASSERT(serializer.serialize(id) == Fw::SerializeStatus::FW_SERIALIZE_OK);