Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Class Prototype? #31

Closed
brhs17 opened this issue Mar 22, 2019 · 13 comments
Closed

No Class Prototype? #31

brhs17 opened this issue Mar 22, 2019 · 13 comments

Comments

@brhs17
Copy link

brhs17 commented Mar 22, 2019

I got this error when trying to rebuild a folder in which I had just run make impl on successfully.
Unkown
@timcanham
Copy link
Collaborator

timcanham commented Mar 23, 2019 •
edited
Loading

It's hard to see what's happening. Is this on a branch?

@brhs17
Copy link
Author

brhs17 commented Mar 23, 2019

Sorry for the delayed response, I put what I currently have on my computer here:
https://github.com/brhs17/fprime/tree/MOpAgg
I messed with a bunch of stuff, but still get similar errors.

@timcanham
Copy link
Collaborator

First issue:

		<event id="104" name="CLEAgg_REQUEST_COMPLETED" severity="ACITIVITY_HI" format_string="Oparation Performed %s" >
		<args>
		<arg nam="val" type="Ref::DataRequest"></arg>
		</args>
		</event>

nam should be name, and ACITIVITY_HI should be ACTIVITY_HI. Sometimes the XML validator script can't tell you where the error is, so you have to use the process of elimination.

In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:48:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLETypes/CLERequestSerializableAc.hpp:25:9: error: redeclaration of ‘GyroX’
         GyroX,
         ^
In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:36:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEPorts/DataRequestPortAc.hpp:25:9: note: previous declaration ‘Ref::DataRequestPortZ GyroX’
         GyroX,
         ^
In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:48:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLETypes/CLERequestSerializableAc.hpp:26:9: error: redeclaration of ‘GyroY’
         GyroY,
         ^
In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:36:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEPorts/DataRequestPortAc.hpp:26:9: note: previous declaration ‘Ref::DataRequestPortZ GyroY’
         GyroY,
         ^
In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:48:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLETypes/CLERequestSerializableAc.hpp:27:9: error: redeclaration of ‘GyroZ’
         GyroZ,
         ^
In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:36:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEPorts/DataRequestPortAc.hpp:27:9: note: previous declaration ‘Ref::DataRequestPortZ GyroZ’
         GyroZ,
         ^
In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:48:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLETypes/CLERequestSerializableAc.hpp:28:9: error: redeclaration of ‘RTCTime’
         RTCTime,
         ^
In file included from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.hpp:36:0,
                 from /mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEAgg/CLEAggComponentAc.cpp:22:
/mnt/c/data/source3/fprime/forks/brhs17/fprime/Ref/CLEPorts/DataRequestPortAc.hpp:28:9: note: previous declaration ‘Ref::DataRequestPortZ RTCTime’
         RTCTime,
         ^

This one is a C++ violation - you have Gyro_* and RTCTime enumeration members declared in two places in the same namespace, in DataRequestPort and CLERequestSerializable.

Once I fixed those two in my clone, the component compiled okay.

@brhs17
Copy link
Author

brhs17 commented Mar 24, 2019

I think I implemented your fixes for CLEAgg, but I still get this error when I try to make rebuild or make impl in the CLEAgg directory:
CLEAgg

Additionally, when I try to make rebuild in the CLEMOps directory, I get this error, which seems completely different:
CLEMOps

I uploaded the changes onto the branch

@rdaruwala
Copy link
Contributor

To fix your AssertionError: Extra element parameters in interleave error, remove

	<parameters>
	</parameters>

from your XML file.

For your second error, my best guess is that those files were generated using an outdated/incorrect XML file. If you delete & remake the Impl cpp/hpp files, they contain DataRequest data instead of options data, which is what's specified by your XML file

@brhs17
Copy link
Author

brhs17 commented Mar 28, 2019

Is there a faster way to compile our code when modifying c files than make rebuild? It seems excessive to wait about 30s just to get errors from one file.

@timcanham
Copy link
Collaborator

You don't have to do a rebuild; just make from the Ref directory will compile the changed files.

@brhs17
Copy link
Author

brhs17 commented Mar 28, 2019

What do I need to do if I realize I made a mistake in an XML file and I have started working on the c files? I named my port items the same as something else, which now causes a collision.

@brhs17
Copy link
Author

brhs17 commented Mar 28, 2019

I edited the port xml file, ran make gen_make in the port directory, and then it compiled. Is there anything else I should do?

@timcanham
Copy link
Collaborator

What I've done in the past is to re-run the make impl target to regenerate the stubs, then copy the new functions from the stubs into my implementation .cpp and .h.

@timcanham
Copy link
Collaborator

You can just recompile the port files; that's all you have to do.

@brhs17
Copy link
Author

brhs17 commented Mar 28, 2019 •
edited
Loading

Why is this 0 required and where does it come from? I had to also put it in my own component.
random0

random02

@timcanham
Copy link
Collaborator

The 0 is the port instance. All ports are arrays of the same port type. If you don't specify max_number in the port declaration in your component, it will default to 1, but you still have to give 0 as the instance in the port call. The port arrays allow you to connect to multiple components that you would invoke in the same way. You can call this->getNum_<PortName>_OutputPorts() if you want your code to automatically scale to the number of ports.

@brhs17 brhs17 closed this as completed Mar 28, 2019
r9-pena added a commit to r9-pena/fprime that referenced this issue Jul 23, 2021
@r9-pena
Test nasa#31
b7edab7
LeStarch pushed a commit that referenced this issue Aug 4, 2021
@r9-pena
Bypass master.bash file in CI (#889)
8fddb8c 
* Create tutorial-support.yml

* Update tutorial-support.yml

GpsApp tutorial to be pulled for build test and submodules to be pulled recursively

* Implementation of tutorial workflow

* typo in repo address

* Added missing github action file

* Changed workflow path

* Changed dir paths

* Work around for workflow

* work around

* troubleshooting

* troubleshoot

* troubleshoot

* Performance update

* Path correction

* troubleshoot

* Dockerfile correction

* path change

* path change

* path fix

* path fix

* path fix

* path fix

* paht fix

* Revert to changes

* Completed workflow for tutorial support

* troubleshoot

* Build path error

* Optimization of workflow

* Path fix

* Path fix

* Path fix #1

* path fix #2

* path check

* Workflow test

* Workflow test #2

* Added logging feature

* Logs Troubleshoot

* Typo fix

* Troubleshoot #1

* Troubleshoot #2

* Corrected typo on path

* Troubleshoot #3

* Troubleshoot #4

* Troubleshoot #5

* Removed log archive feature

* Changed repo path to conform pull request merge

* Test run #1

* test #2

* test #3

* added branch for workflow test

* test #4

* test #4

* test #5

* test #6

* Test #7

* test #8

* test #8

* Test #9

* Test #9

* Test #10

* Test #11

* Test #12

* Test #13

* Test #14

* Test #15

* Test #16

* Test #17

* Test #18

* Test #20

* Test #21

* Test #22

* Test #23

* Test #24

* Test #25

* Split test files

* Split tests #2

* Added executable permissions

* Delete RPI.bash

* Delete Ref.bash

* Delete Framework.bash

* exe files

* Make Framework.bash executable

* Make RPI.bash and Ref.bash executable

* Test #26

* Test #27

* Test #28

* Attached Integration test to Ref test

* Test #29

* Test #30

* Test #31

* Test #32

* Test #33

* Test #34

* Test #35

* Test #35

* Test #37

* Test #38

* Test #39

* Test #40

* Test #41

* Test #42

* Test #43

* Test #43

* Test #44

* Test #45

* Cleaned up files to remove commented code

* Remove CI test branch from workflow

* Incorporated comments for PR

* Modified path for framework job test

* Incoporate reviewer comment for PR

* Incoporated reviewer comment for PR

* Was using incorrect directory for the test

* Revised args call for jobs

* Passing args #1

* Define entrypoint directly from workflow

* Changed entrypoint method

* Changed entrypoint method #2

* Corrected test path

* Syntax correction

* Path Test #1

* Path test #2

* Path Test #4

* Path Test $5

* Test Path #6

* Path Test #6

* Path Test #7

* Path Test #8

* Refactored scripts to remove master.bash

* Corrected test path

* Fixed log problems

* Entrypoint alternative

* Bypassed master.bash file

* Added line for better CI error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timcanham @rdaruwala @brhs17