Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update MathComponent to Reference TestMain #1030

Merged
merged 2 commits into from
Sep 16, 2021
Merged

docs: Update MathComponent to Reference TestMain #1030

merged 2 commits into from
Sep 16, 2021

Conversation

astroesteban
Copy link
Contributor

Originating Project/Creator @astroesteban
Affected Component Docs
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

The existing MathComponent unit test tutorial instructs the user to create a main.cpp test file even though running fprime-util impl --ut creates a new TestMain.cpp file. The changes update the Tutorial.md file to reflect this new functionality and now instruct the user to modify the autogenerated TutorialMain.cpp file instead of creating a main.cpp file.

In addition, the existing main.cpp files for the MathSender & MathReceiver components have been renamed to TestMain.cpp.

Rationale

Update the docs to reflect more features provided by fprime-util impl --ut

Testing/Review Recommendations

  • Review the renaming of main to TestMain.

Future Work

The existing MathComponent tutorial references a `main.cpp` test file
that has been replaced by an autogenerated TestMain.cpp file. The
docs have been updated to reference the TestMain file instead of
the old manually created main.cpp file.
@astroesteban astroesteban changed the title docs: MathComponent References TestMain docs: Update MathComponent to Reference TestMain Sep 12, 2021
@LeStarch
Copy link
Collaborator

@astroesteban thanks! I added a few more fixes w.r.t. TesterBase and GTestBase files being autocoded.

@LeStarch LeStarch self-requested a review September 16, 2021 19:32
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@astroesteban
Copy link
Contributor Author

astroesteban commented Sep 16, 2021

Thanks for those extra fixes @LeStarch!

@LeStarch
Copy link
Collaborator

@astroesteban you did the work, I was just cleaning up an old issue.

@LeStarch LeStarch merged commit 567e2c5 into nasa:devel Sep 16, 2021
@astroesteban astroesteban deleted the docs/update-utest-main-source-file-ref branch September 16, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants