Fixed bugs found while compiling for baremetal. #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the operator=. Updating the expected line numbers to match where the asserts are now.
bocchino
requested changes
May 18, 2022
Autocoders/Python/src/fprime_ac/generators/templates/enums/enum_cpp.tmpl
Outdated
Show resolved
Hide resolved
Autocoders/Python/src/fprime_ac/generators/templates/enums/enum_cpp.tmpl
Outdated
Show resolved
Hide resolved
bocchino
reviewed
May 24, 2022
Autocoders/Python/src/fprime_ac/generators/templates/enums/enum_hpp.tmpl
Outdated
Show resolved
Hide resolved
LeStarch
pushed a commit
that referenced
this pull request
Jun 29, 2022
* Fixed bugs found while compiling for baremetal. * line number in which assert occurs has changed due to the addition of the operator=. Updating the expected line numbers to match where the asserts are now. * addressing pr comments. * updated line numbers in unit test to match what is auto generated. * fixed comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Discovered a lack of
operator=for enum in Autocoder's template files.A mismatch in function definition with its prototype in BufferLogger.
An invalid casting in PolyType
Rationale
Fixes bugs found while compiling for baremetal
Testing/Review Recommendations
Re-run the UTs on your side.
Future Work