Replace lists created with list() with [] #1471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR replaces lists created with
list()
with[]
ref.Rationale
The
[]
notation is the most concise and Pythonic way to create a list.It corresponds to the way we create lists with elements, which saves some of the mental energy that would otherwise be consumed by considering two different ways of creating lists.
This method has the added benefit of providing a minor performance boost. Here are the times prior to and following the change:
Testing/Review Recommendations
(none)
Future Work
I'm not sure I caught them all.