Remove built-in function len
used as condition
#1499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR changes the way to determine if a sequence is empty with
len
by computing its boolean value.Rationale
Using the
len
function to determine whether a sequence is empty is not idiomatic and may be less efficient than determining the veracity of the object.len
does not know the context in which it is called, so computing the length requires traversing the entire sequence. It does not know that the result is simply compared to0
.Regardless of the length of the sequence, the boolean value calculation may stop after seeing the first element.
Testing/Review Recommendations
void
Future Work
void