Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-in function len used as condition #1499

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

ThibFrgsGmz
Copy link
Contributor

Originating Project/Creator @ThibFrgsGmz
Affected Component python autocoder
Affected Architectures(s)
Related Issue(s) void
Has Unit Tests (y/n) n
Builds Without Errors (y/n) Let CI run
Unit Tests Pass (y/n) Let CI run
Documentation Included (y/n) n

Change Description

This PR changes the way to determine if a sequence is empty with len by computing its boolean value.

Rationale

Using the len function to determine whether a sequence is empty is not idiomatic and may be less efficient than determining the veracity of the object.

len does not know the context in which it is called, so computing the length requires traversing the entire sequence. It does not know that the result is simply compared to 0.

Regardless of the length of the sequence, the boolean value calculation may stop after seeing the first element.

Testing/Review Recommendations

void

Future Work

void

@LeStarch LeStarch merged commit 7c3e606 into nasa:devel Jun 21, 2022
@ThibFrgsGmz ThibFrgsGmz deleted the feat/builtin_len_as_condition branch September 3, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants