Migrate away from C-style enum constructs for Os/Queue.hpp
#1589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Switch from the
typedef enum { ... } enumName;
construct toenum enumName { ... };
instead.Rationale
typedef
is not required when declaring enumerations in C++ to avoid the prepended use of theenum
keyword when using the enum post-declaration.Testing/Review Recommendations
Going with one file per PR!
Future Work
Making this minor change for similar typedef-aliased enum declarations in other files