Update link to CFDP PDF in sdd.md #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The old link, http://public.ccsds.org/publications/archive/727x0b4.pdf, yields 404. Hence update it to https://public.ccsds.org/Pubs/727x0b4s.pdf.
Rationale
Just fixes a link.
Though more context:
I went looking for the old link in the archive: https://web.archive.org/web/20160101000000*/http://public.ccsds.org/publications/archive/727x0b4.pdf
Found the latest version captured here: https://web.archive.org/web/20160402232332/http://public.ccsds.org/publications/archive/727x0b4.pdf
Searched for the filename and landed here: https://public.ccsds.org/Pubs/Forms/AllItems.aspx?Paged=TRUE&p_SortBehavior=0&p_FileLeafRef=727x0b4%2Epdf&p_ID=261&PageFirstRow=301&&View=%7B14363EEB-D5D0-48AC-8125-D884CCA0614C%7D.
→ The new live link, https://public.ccsds.org/Pubs/727x0b4s.pdf, contains an additional "s" in the file name as well as one page more, the first one - both seemingly (just) to indicate the succession.
Testing/Review Recommendations
The review is probably only checking if the link is truly correct.
Future Work
Potentially pointing the link to CCSDS 727.0-B-5, which would be https://public.ccsds.org/Pubs/727x0b5.pdf, instead of the now historical 727.0-B-4 (5 instead of 4). However the contents of the mentioned section 4.1.2 seem to have changed substantially (seemingly: been split) and I don't have the expertise to confirm if it actually stayed the same.