Raise proper exceptions in python generators #1660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Change exception classes to less broad. E.g. Exception -> NotImplementedError
Rationale
Raising and catching `Exception' directly is not recommended in python. There are plenty built in exceptions to be used instead.
Testing/Review Recommendations
Please refer to python2 docs
https://python.readthedocs.io/en/v2.7.2/library/exceptions.html
Future Work
Consider migrating to python3, as python2 EOL is already reached.