Remove LGTM badges from README.md #1816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Removes LGTM badges from the project homepage. Currently the badget shows "lgtm invalid".
Rationale
See:
Testing/Review Recommendations
I spotted some instructions for LGTM in the code base like :
fprime/Fw/Types/Serializable.cpp
Line 60 in 91c578e
fprime/Fw/Types/StringType.cpp
Line 105 in 91c578e
fprime/Svc/FileDownlink/FileDownlink.cpp
Line 152 in 91c578e
fprime/Svc/FileDownlink/FileDownlink.cpp
Line 153 in 91c578e
I don't know if we should delete them because they would be deprecated, i.e. I don't know if CodeQL takes them.
Future Work
None